[LLVMdev] [PATCH] Start of SIMD Reorg

[Bruno Cardoso Lopes]

Hi David,

On Fri, Jul 9, 2010 at 3:25 PM, David Greene <dag at cray.com> wrote:
> Now that Bruno is putting in some AVX stuff, it's a good motivator to
> move my x86 SIMD reorg work into trunk (and got management to agree to
> prioritize it - Thanks Bruno! :) ).
>
> Attached is the first patch of many to accomplish this.  The overall
> goal is to have all x86 SIMD instructions share a set of common patterns
> so that we can have a more maintainable machine description (e.g. SS,
> SD, PS, PD, 128-bit, 256-bit ADD all look similar other than opcode
> prefixes).
>
> This patch merely moves some common pattern fragments (memop,
> alignedload, etc.) to a file separate from X86InstrSSE.td so that all
> current x86 SIMD implementations can still use the classes while the
> transition happens.
>
> Ok to commit?

I'm Ok with this patch.

Despite that, I think we should discuss the ones to come, If you really go
"tablegen auto generates everything" as I've noticed in some tablegen patches
you commited, there's a great chance the sse/avx code would become unreadable,
I think this is harder to maintain and improve.

Thanks,

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc