[LLVMdev] RFC: New Linkage Type linker_private_weak

[Chris Lattner]

Awesome, thanks Bill!

-Chris

On Jul 1, 2010, at 1:38 AM, Bill Wendling <wendling at apple.com> wrote:

> On Jun 30, 2010, at 9:52 PM, Chris Lattner wrote:
> 
>> On Jun 30, 2010, at 1:36 PM, Bill Wendling wrote:
>> 
>>> I implemented the new linkage to have its own prefix from linker_private. As it currently stands, the symbol's prefix ("l") is the same for "linker_private" and "linker_private_weak". If this will always be the case, then I can remove the code in my patch that allows for a different prefix.
>> 
>> I'm quite certain that it will always be the case :), please remove MAI::LinkerPrivateWeakGlobalPrefix and Mangler::LinkerPrivateWeak.
>> 
> Okay. I'll go ahead and make this change. I'm not a big fan (I'd rather it be more general), but I'm not going to stand in the way of getting this to work either. :)
> 
>> Otherwise, the patch looks good.  Please commit it with 1) a testcase showing the next linkage type round trips through llvm-as/llvm-dis (in llvm/test/Feature/)   2) a codegen test for at least one darwin target that filechecks that the right directives are being generated.   3) a LangRef.html patch.
>> 
> Yup! I already have these in my tree, more or less. :)
> 
>> Thanks again for working on this!
>> 
> Sure!
> 
> -bw
>