[LLVMdev] ambiguity of .align

[Chris Lattner]

On Jan 26, 2010, at 10:06 AM, Rafael Espindola wrote:

> 2010/1/25 Sandeep Patel <deeppatel1987 at gmail.com>:
>> Assuming you're working with an ARM target, you may also hit a  
>> problem
>> with the alignment option on the .comm directive.
>>
>> Attached is a first-cut patch for this latter problem.
>
> I have updated your patch to reflect the recent changes. I have also
> updated the tests. I have checked that it produces
> ---------------------------
> .comm   bar,75,128
> ----------------------------
>
> and
>
> ---------------------
>        .align  7
> foo:
> --------------------
>
> and that that is what gas for ARM expects.
>
>
> Chris, do you think it is OK?

Patch looks good to me.  Please put a comment in the ARM MCAsmInfo  
sayings ".comm align is in bytes but .align is pow-2." or something  
like that.  Thanks!

-Chris