[LLVMdev] LangRef 'struct' patch--preliminary

Jeffrey Yasskin jyasskin at google.com
Mon Jan 11 13:05:55 PST 2010


On Mon, Jan 11, 2010 at 11:31 AM, Dustin Laurence
<dllaurence at dslextreme.com> wrote:
> On 01/11/2010 11:20 AM, Jeffrey Yasskin wrote:
>> Awesome, thanks! Committed as r93170 with the following change:
>>
>> s/local variables/registers/. "Local variable" refers to allocas in
>> LLVM, rather than %whatever SSA "variables".
>
> Excellent.  I was not actually happy with that term when I wrote it, but
> wasn't sure of the standard terminology.  It should certainly be
> consistent, and that way makes more sense.
>
> If these patches are useful I'll send more, but I should know one thing.
> I notice that the example code in the LangRef is not formatted
> consistently; sometimes in a grey box, sometimes just inline.  My guess
> is the preferred format changed at some point and older ones are just
> not updated yet.  I left the format as I found it this time, but tell me
> which is preferred and I'll try to always put examples in the newer format.

Patches that make the docs easier to understand are definitely useful.
 I'm not sure about the desired state for example code. I'd probably
leave things the way you find them.




More information about the llvm-dev mailing list