[LLVMdev] Metadata [volatile bug?]

David Greene dag at cray.com
Fri Feb 12 07:27:29 PST 2010


On Thursday 11 February 2010 20:05:25 Dan Gohman wrote:

> > Shouldn't that be MMO->isVolatile()?
>
> It's not a bug; the code could be written either way. There's actually
> an assert in MemSDNode's constructor which checks that they're the
> same. I believe the code is structured this way because it makes it
> easy to lump the volatile flag in with other data which is
> significant for CSE purposes, but it's not critical that it work
> that way.

Ah, I see that now.  Will I need to do the same with the NonTemporal
flag to make it "significant?"

It's a bit jarring to see the other boolean operations work through the
MMO and then see isVolatile mess with SubclassData.

                                                 -Dave




More information about the llvm-dev mailing list