[LLVMdev] tblgen internals

Garrison Venn gvenn.cfe.dev at gmail.com
Sun Dec 12 10:54:44 PST 2010


Hey Chris,

The following patch removes all global references to a RecordKeeper instance for the tblgen
utility. This effort was motivated by the FIXME remark, in TableGen.cpp. Although a few files 
were touched, the main change was to Record.h.

The patch takes the simple approach of adding a RecordKeeper reference to TGParser, and 
any needed emitter helper classes. In addition, since some of the classes, and methods in Record 
reference the previously global RecordKeeper instance, I added another RecordKeeper 
reference to Record, along with such a typed argument to Record's constructor, and a 
corresponding factory method to RecordKeeper.

Do you want to proceed with this approach, or are there any tweaks you want made?

Garrison

PS: This patch is standalone with respect to trunk: 121636


-------------- next part --------------
A non-text attachment was scrubbed...
Name: RecordKeeper.3.patch
Type: application/octet-stream
Size: 22641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101212/a61b1e79/attachment.obj>


More information about the llvm-dev mailing list