[LLVMdev] [cfe-dev] draft rule for naming types/functions/variables

[Chris Lattner]

On Dec 1, 2010, at 9:32 PM, Zhanyong Wan (λx.x x) wrote:

> Hi,
> 
> I uploaded a patch for the "*Kind enum" rule to
> 
> http://codereview.appspot.com/3402041
> 
> and attached it to this message too.  Would you please take a look?  Thanks,

Applied, thanks!  After applying it, I went through and restructured the section for readability:
http://llvm.org/docs/CodingStandards.html#ll_naming

-Chris

> 
> On Wed, Dec 1, 2010 at 9:19 PM, Zhanyong Wan (λx.x x) <wan at google.com> wrote:
>> Thanks, Chris and John.  Committed in r120689.  I'll try to add the
>> *Kind rule in a separate patch.  Cheers,
>> 
>> On Wed, Dec 1, 2010 at 5:18 PM, Chris Lattner <clattner at apple.com> wrote:
>>> 
>>> On Nov 30, 2010, at 11:29 PM, Zhanyong Wan (λx.x x) wrote:
>>> 
>>>> Hi Chris,
>>>> 
>>>> I've uploaded a new patch to http://codereview.appspot.com/3264041.
>>>> It's also attached to this message.
>>> 
>>> This patch looks great to me, please apply, thanks!
>>> 
>>>> I think I've addressed all your comments, except "when in doubt, an
>>>> enum should be a 'Kind'".  I don't think I fully understand that
>>>> point, and it strikes me as a bit ad hoc for the coding standards.  Do
>>>> we really want it?
>>> 
>>> John's email sums it up really well, but I'm fine tackling this as a separate step.
>>> 
>>> -Chris
>> 
>> 
>> 
>> --
>> Zhanyong
>> 
> 
> 
> 
> -- 
> Zhanyong
> <kind-enum.patch>