[LLVMdev] [llvm-commits] [llvm] r81845 - in /llvm/trunk: lib/VMCore/ConstantFold.cpp test/Assembler/insertextractvalue.ll
nicholas at mxc.ca
Mon Sep 14 23:33:27 PDT 2009
Chris Lattner wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=81845&view=rev
> fix PR4963: folding insertvalue would sometimes turn a packed struct into
> an unpacked one.
About this bug -- it happened because ConstantStruct::get has a default
parameter for whether the struct should be packed or not, which defaults
to not packed.
This is strikingly error prone. We even list struct and packed struct as
two different types in the LangRef. We don't need to go so far as to
offer separate ConstantStruct and ConstantPackedStruct but maybe the
isPacked parameter should at least be mandatory?
More information about the llvm-dev