[LLVMdev] PR4882
Duncan Sands
baldrick at free.fr
Mon Sep 7 12:02:03 PDT 2009
Hi Jakub, looks good.
> + LLVMContext *Context = &SI->getContext();
I guess this could be
LLVMContext &Context = SI->getContext();
which means you can use Context rather than *Context below.
> - const Type *Ty = Type::getInt64Ty(SI->getContext());
> - MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset, &Ty, 1);
> + const Type *Tys[] = {Type::getInt64Ty(*Context)};
> + MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,
> + Tys, 1);
Why did you introduce Tys and not stick with Ty?
Ciao,
Duncan.
More information about the llvm-dev
mailing list