[LLVMdev] Possible bug in ExpandShiftWithUnknownAmountBit

[Eli Friedman]

On Mon, Nov 30, 2009 at 7:22 PM, Javier Martinez <javier at jmartinez.org> wrote:
> Hello,
>
> I'm working in adding support for 64-bit integers to my target. I'm using
> LLVM to decompose the 64-bit integer operations by using 32-bit registers
> wherever possible and emulating support where not. When looking at the bit
> shift decomposition I saw what seems to be a bug in the implementation. The
> affected function is ExpandShiftWithUnknownAmountBit in
> LegalizeIntegerTypes.cpp. Below is the original code and the proposed fix.
> Could someone please review the changes? If they are correct how do I go
> about submitting a patch?

[snip]

Please use "svn diff" to generate proposed patches; the form you used
is extremely difficult to read.

-Eli