[LLVMdev] PR5373

[Dan Gohman]

Hello,

Simply removing that "return true" causes the code to search
blocks outside of loops for side effects. That's not
what the code is supposed to do.

Dan

On Nov 27, 2009, at 3:01 AM, Jakub Staszak wrote:

> Hi,
> 
> Because of this "return true" not every block was visited and only one ExitBB was found (instead of two). Thus, loop was optimized as a trivial one, which was wrong.
> 
> -Jakub
> 
> On Nov 24, 2009, at 2:28 PM, Dan Gohman wrote:
> 
>> Hello,
>> 
>> I haven't studied this in detail, but at a first look this makes the code inconsistent with the associated comments. Why should the code continue recursing past a loop exit?
>> 
>> Dan
>> 
>> On Nov 23, 2009, at 4:43 AM, Jakub Staszak <kuba at gcc.gnu.org> wrote:
>> 
>>> Hello,
>>> 
>>> This patch fixes pr5373, testcase of course attached.
>>> 
>>> -Jakub
>>> <5373.patch>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>