[LLVMdev] DeadStoreElimination: do better without TargetData

Chris Lattner clattner at apple.com
Fri Nov 6 09:32:36 PST 2009


On Nov 5, 2009, at 1:59 PM, Hans Wennborg wrote:

> My apologies for not replying sooner; I've been away from keyboard all
> day today.
>
>> Thanks, applied here:
>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20091102/090396.html
>>
>>
>> I'd appreciate it if you could resend your other patches in patch  
>> format
>> like this, attached to the email with the testcase using filecheck.
>> This commit should be a good example.  Thanks for helping improve  
>> this
>> area!
>>
>
> I'm not sure I follow you completely here. You want me to resend to
> llvmdev, right -- not llvm-commits?

Sure, either way works.

>
> What is the difference between the patch format i used and the one you
> refer to, except for the testcase?
> Is this filecheck thing documented somwhere?

Specifically, please send it as an attachment instead of inline:
http://llvm.org/docs/DeveloperPolicy.html#patches

This makes it easier to apply.  FileCheck is documented here:
http://llvm.org/docs/TestingGuide.html#FileCheck

Thanks!

-Chris



More information about the llvm-dev mailing list