[LLVMdev] x86 Intel Syntax and MASM 9.x

[Gaster, Benedict]

Hi Eli,

Sorry about that Visual Studio seems to have inserted tabs and I used an
internal diff tool. Anyway, I synced TOT LLVM and made the changes with
Emacs and the svn diff is attached.

Regards,

Ben

-----Original Message-----
From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu]
On Behalf Of Eli Friedman
Sent: Tuesday, June 16, 2009 11:19 AM
To: LLVM Developers Mailing List
Subject: Re: [LLVMdev] x86 Intel Syntax and MASM 9.x

On Tue, Jun 16, 2009 at 9:39 AM, Gaster,
Benedict<Benedict.Gaster at amd.com> wrote:
> Hi Eli,
>
> Yep I was being stupid.
>
> Please find attached a patch for initial changes to get MASM working.

Patch looks fine except that it has tabs (LLVM uses only spaces for
indentation).  Also, can you generate the patch using "svn diff"?
It's currently in some unusual format which "patch" doesn't recognize.

> There is still one problem that I am looking into around changing
> alignments within SEGMENTS. The problem is that MASM allows 2,4,16,256
> alignments, default being 16, but LLVM is sometimes generating 32
> alignment, for example, consider the following code:

Huh.  For correctness, I guess you'll have to round up the alignment,
and abort on anything higher than 256.  (Also, perhaps the front-end
should avoid generating such constructs in the first place when
targeting Windows, but that's a separate issue.)

-Eli
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: masm.diff
Type: application/octet-stream
Size: 14450 bytes
Desc: masm.diff
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090616/dce8d0f6/attachment.obj>