[LLVMdev] RFC: Constant Creation API

Owen Anderson resistor at mac.com
Thu Jul 23 19:35:19 PDT 2009

So, as you all probably noticed, the APIs for creating constants have  
been moved (or in a specific cases, are about to be moved) from static  
methods on Constant to instance methods on LLVMContext.

However, as was recently pointed out on llvm-commits and on IRC, this  
is no longer strictly necessary.  Because types have contexts, all of  
the constant subclasses could be friended to LLVMContext, and then put  
the work of uniquing by accessing the context off of the type.

There are obviously some pros and to both approaches.  Going back to  
the old-style increases compatibility with 2.5, and breaks up the  
massive LLVMContext class.  On the downside, it would cause massive  
thrashing on TOT, because I will have to revert about two weeks worth  
of commits in widely dispersed parts of the tree, and because a number  
of clients have already switched to the new TOT API.

Any comments and/or opinions on this decision are welcome.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090723/cbd2a78c/attachment.bin>

More information about the llvm-dev mailing list