[LLVMdev] [PATCH] Support asm comment output

Chris Lattner clattner at apple.com
Tue Jul 14 17:17:09 PDT 2009

On Jul 14, 2009, at 3:10 PM, David Greene wrote:

> On Tuesday 14 July 2009 15:35, David Greene wrote:
>> On Monday 13 July 2009 15:58, David Greene wrote:
>>> Again, after answering the FI stack slot question, the IR-level
>>> instruction information is the only thing we can't do through  
>>> asmprinter.
>>> I'm open to other ways of capturing the information that don't  
>>> require
>>> comments in MachineInstrs.  But the information has to be stored
>>> somewhere.
>> Ugh.  I just found another case I don't think we can synthesize in
>> asmprinter. We mark rematerialized instructions as well so our  
>> performance
>> guys don't come and ask us why we didn't hoist saomething out of a  
>> loop.
>> :)
> Here's another question.  If we mark StackObjects as spill slots,  
> isn't it
> possible that stack slot coloring could come along and assign non- 
> spill/reload
> memory objects to the same slot?  If so, it would appear we really  
> do need
> a flag on MachineInstr to notate all spills and reloads.

Dave, lets start with the simple stuff and get it working first.  We  
can feature creep it after that :)


More information about the llvm-dev mailing list