[LLVMdev] cygwin build patch

Chris Lattner clattner at apple.com
Tue Jan 20 10:23:55 PST 2009


On Jan 20, 2009, at 1:22 AM, Jay Foad wrote:

>>> I realise that the DataTypes.h.in part might be controversial. Also,
>>> there's probably a better place to put it, but I'm not sure where.
>>
>> I didn't apply this part.  What problems does it cause to not have
>> this?  Can we fix uses of max and min?
>
> I could try to fix this by changing the code to consistently use
> either unsigned or uint32_t (which?), rather than both. Or by adding
> casts at the point of calling min/max. What would you prefer?

I'd prefer to avoid uint32_t.  I committed a couple patches, can you  
try again and let me know if you see any other failures?

-Chris



More information about the llvm-dev mailing list