[LLVMdev] svn pre-commit hook: help needed

Scott Michel scooter.phd at gmail.com
Tue Feb 17 14:46:46 PST 2009


On Tue, Feb 17, 2009 at 2:35 PM, Mike Stump <mrs at apple.com> wrote:

> On Feb 17, 2009, at 2:21 PM, Scott Michel wrote:
> > - remove trailing whitespace,
> > - expand tabs to spaces,
>
> I'd argue for not changing anything, just fail it.
>

Trimming whitespace is innocuous, at best. Expanding tabs to spaces, I might
be inclined to agree is a 'fail' since weird formatting can result. 80-col
violations are absolutely a 'fail'.


-scooter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090217/1d7dfed3/attachment.html>


More information about the llvm-dev mailing list