[LLVMdev] Some enhancements to ImmutableSet and FoldingSet

Bill Wendling isanbard at gmail.com
Wed Feb 11 10:54:29 PST 2009


On Wed, Feb 11, 2009 at 10:36 AM, Ben Laurie <benl at google.com> wrote:
> I needed these for some work I'm doing in clang...
>
Yes sir! At least this message was informative. One thing:

+  int size() const {
+    int n = 0;
+    for(iterator i = begin() ; i != end() ; ++n, ++i)
+      ;
+    return n;
+  }
+  bool empty() const {
+    return size() == 0;
+  }

empty() here isn't a constant-time method. Can you make it's time
complexity O(1)?

-bw



More information about the llvm-dev mailing list