[LLVMdev] A patch for refine the cmake system. Also rmoved file iterator.cmake and DataTypes.cmake

Óscar Fuentes ofv at wanadoo.es
Wed Aug 26 07:13:18 PDT 2009


"罗勇刚(Yonggang Luo)"  <luoyonggang at gmail.com> writes:

> Anyway, because msvc doesn't support flag -fPIC, so I disable it.  And
> must update configure, but I didn't do that, because I don't get the
> env.  But I update configure.ac, from my point's of view. but don't
> even have a try.
>
> I got two patch, but the one of them is little complex more because I
> add #ifdef in config.h
> and another one is clearer, but I don't know if the clearer one  is
> safe enough:)

In your patch there are several interesting things (the detection for
iterators, for instance).

However, it contains serious flaws:

include/llvm/Support/DataTypes.h does not exist on the LLVM sources. It
is created by configure or cmake. For avoiding this kind of mistakes
always use a directory outside the llvm sourcers hierarchy for building.

Do not mix in the same patch changes for cmake and configure.

Reduce the patch to the minimum required. This includes avoiding
whitespace changes.

-- 
Óscar




More information about the llvm-dev mailing list