[LLVMdev] Patch: Compiling LLVM in Sparc
Venkatraman Govindaraju
venkatra at cs.wisc.edu
Tue Aug 25 07:49:43 PDT 2009
Instead of just upcasing them, can we add prefix ARCH_?
--Venkatraman
On Tue, Aug 25, 2009 at 2:36 AM, Eric Christopher<echristo at apple.com> wrote:
>
> On Aug 25, 2009, at 12:32 AM, Daniel Dunbar wrote:
>
>> Hi,
>>
>> I think I should rename the constants to be a little less likely to
>> collide. I think just upcasing them might be good enough?
>
> It should, this is the pattern generally emitted by all of the backends.
>
>>>>
>>>> $ cpp -dM /dev/null | grep sparc
>>>> #define sparc 1
>>>> #define __sparc__ 1
>>>> #define __sparc 1
>
> There's likely an all uppercase one as well, but afaik no camel case one.
>
> -eric
>
More information about the llvm-dev
mailing list