[LLVMdev] Buggy assertion in APFloat::convertFromHexadecimalString

[Daniel Dunbar]

Fixed in r79450, along with an additional one of the same nature.

Thanks,
 - Daniel

On Thu, Aug 20, 2009 at 7:42 AM, Enea Zaffanella<zaffanella at cs.unipr.it> wrote:
> Hello.
>
> When running clang in Debug mode, I am getting an assertion failure when
> parsing the following line:
>
> float ko = 0x1.1p0;
>
> Apparently, the recent changes in the use of StringRef haven't been
> propagated to all places. Please find attached the trivial patch.
>
> Cheers,
> Enea Zaffanella.
>
>
> Index: lib/Support/APFloat.cpp
> ===================================================================
> --- lib/Support/APFloat.cpp     (revision 79510)
> +++ lib/Support/APFloat.cpp     (working copy)
> @@ -2153,7 +2153,7 @@
>     integerPart hex_value;
>
>     if(*p == '.') {
> -      assert(dot == 0);
> +      assert(dot == s.end());
>       dot = p++;
>     }
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>