[LLVMdev] modify cmakefiles to set the default triple of msvc and mingw to i686-pc-mingw

Óscar Fuentes ofv at wanadoo.es
Sun Aug 9 10:03:48 PDT 2009


"罗勇刚(Yonggang Luo)"  <luoyonggang at gmail.com> writes:

> because on windows platform. i686-pc-winnt is not mature and even
> don't working. So the it's better to set it to mingw.

Is this right? There are some differences among mingw and msvc (the C++
`this' calling convention, for instance).

BTW, it's i686-pc-win32, not i686-pc-winnt.

> And also those spaces and indent modify is just because of the
> original indent is not consistent.

One patch, one fix. Every svn commit must have a precise purpose and be
as concise as possible. If you want to fix whitespace inconsistencies,
submit a separate patch.

> Also, now msvc support multiple target. So it's better to set it as
> ${LLVM_ALL_TARGETS}
> It's can working, why not set it to:.

I think most LLVM users on Windows are interested on X86 only. This
saves a lot of time on the build process and creates smaller
executables. Anyways, it they want all targets, it is simply a matter of
passing -DLLVM_TARGETS_TO_BUILD=all on the cmake command line.

-- 
Óscar




More information about the llvm-dev mailing list