[LLVMdev] llvm/test: suffix or operands invalid for `push'

[Chris Lattner]

On Mar 6, 2008, at 12:08 AM, Joachim Durchholz wrote:

>
> Am Mittwoch, den 05.03.2008, 23:03 -0800 schrieb Chris Lattner:
>> On Mar 3, 2008, at 2:49 AM, Joachim Durchholz wrote:
>>
>>> Hi all,
>>>
>>> I found enough to explain the behaviour that I encountered. If I'm
>>> correct, the bugs are just in the dejagnu-based test machinery,  
>>> not in
>>> LLVM itself.
>>
>> Yep, I believe that.  I haven't been following the whole thread very
>> closely, what specific tests are affected here?
>
> test/C++Frontend/2006-11-06-StackTrace.cpp
> test/C++Frontend/2006-11-30-NoCompileUnit.cpp
> test/C++Frontend/2006-11-30-Pubnames.cpp
>
>> Before making any significant and widespread changes to llvm/test,
>> please change one test and propose it as a model for other tests.
>
> The changes were actually very local: replace calls to gcc/g++/as with
> calls to %compile_c and %compile_cxx.
> I submitted bug reports with patches recently (look for bugs submitted
> by jo at durchholz.org). The patches are tiny, so it's not a real problem
> if they need to be modified, and I'm willing to try out any needed
> modifications and resubmit the patches.
> (%compile_cxx wouldn't work because %compile_c would be substituted
> before, so the first patch corrects that.)

Makes sense!  I applied your patch, thanks!

-Chris