[LLVMdev] [patch] add support for PIC on linux x86-64

Rafael Espindola espindola at google.com
Sat Jun 7 02:36:40 PDT 2008


> Yes, please remove PICCallStyle and have printPLT check for pic
> relocation model and Subtarget.isTargetELF().

Done.

> And where you are modifying this part of the code. Please rename
> printGOT, printStub, and printPLT to something that indicates they are
> predicate functions. Perhaps shouldPrintGOT, etc.?

Done.

Updated patch attached.

> Thanks,
>
> Evan

Cheers,
-- 
Rafael Avila de Espindola

Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland

Registered in Dublin, Ireland
Registration Number: 368047
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86-64-plt.patch
Type: application/octet-stream
Size: 8097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080607/d5bb2043/attachment.obj>


More information about the llvm-dev mailing list