[LLVMdev] [PATCH] patch to compile llvm-gcc using nightly tester script(NewNightlyTester.pl)

[Bill Wendling]

On Mon, Jul 7, 2008 at 11:10 AM, Rajika Kumarasiri <rajikacc at gmail.com> wrote:
> hello everybody,
>
> I have added few improvements to my patch. Please review the new patch
> directly.
> Thanks!
>
Hi Rajika,

A few stylistic comments. I'll let others comment on the algorithm for now:

     if ($VERBOSE) {
       print "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; " .
-            "$SVNCMD/test-suite/trunk llvm-test ) > $COLog 2>&1\n";
+            "$SVNCMD/test-suite/trunk llvm-test ; cd ../../;" .
+	    "$SVNCMD/llvm-gcc-4.2/trunk dst-directory ) > $COLog 2>&1\n";
     }
     system "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; " .
-          "$SVNCMD/test-suite/trunk llvm-test ) > $COLog 2>&1\n";
+          "$SVNCMD/test-suite/trunk llvm-test ; cd ../../;" .
+	  "$SVNCMD/llvm-gcc-4.2/trunk dst-directory ) > $COLog 2>&1\n";

This could be done with something like this:

     my $cmd = "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; " .
              "$SVNCMD/llvm-gcc-4.2/trunk dst-directory; " .
              "cd llvm/projects; " .
              "$SVNCMD/test-suite/trunk llvm-test ) > $COLog 2>&1\n";

     print $cmd if ($VERBOSE);
     system $cmd;

This could be done in other spots that do similar things as well.
Also, why not name the LLVM-GCC source directory something other than
"dst-directory"? Maybe "llvm-gcc.src" or similar? You add a few
extraneous newlines in the code. Please remove those.

-    my $CVSCMD = "$NICE cvs $CVSOPT -d $CVSRootDir co -P $CVSCOOPT";
+    my $CVSCMD = "$NICE cvs $CVSOPT -d $CVSRootDir co -P $CVSCOOPT";
# TODO, do we still maintain the CVS tree ?

80-column violation here and in other places. Put the comment before
here. (And, no, we don't maintain the CVS tree anymore.)

-bw