[LLVMdev] Unit test patch, updated

[Misha Brukman]

2008/12/31 Chris Lattner <clattner at apple.com>

> On Dec 30, 2008, at 2:54 PM, Talin wrote:
>
> OK changes made and new patch attached.
>
> +++ utils/unittest/Makefile (revision 0)
>
> ...
> +# This has to come after Makefile.common, since it doesn't allow us to
> +# override the VPATH value unless we set PROJECT_NAME, which we don't want
> +# to do.
> +VPATH = $(LLVM_SRC_ROOT)/utils/unittest/googletest/src/
>
>
> Why play with VPATH here?  What is this doing?  Can this be handled a
> different way?  Similarly in makefile.unittest.
>

Removed VPATH in this file by moving GTest up one directory, and added
VPATH-less Makefiles:
http://llvm.org/viewvc/llvm-project?view=rev&revision=61539
http://llvm.org/viewvc/llvm-project?view=rev&revision=61540 (minor revision)

Also removed VPATH from Makefile.unittest (see link below).

+++ unittests/ADT/DenseMapTest.cpp (revision 0)
> +namespace {
> +
> +using namespace llvm;
>
>
> Please put the 'using' right after the #includes.
>

Done.


> Otherwise, the patch looks good to me.  Please verify that it works with
> both a SRCDIR=OBJDIR and SRCDIR!=OBJDIR build.
>

Done for both; passes both with flying colors.
Submitted: http://llvm.org/viewvc/llvm-project?view=rev&revision=61541

Thanks to Talin for the original patch.

Now everyone can go write some unittests!

Misha

P.S.  Why are you still reading?  Go!  Write!  Test!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20081231/d90717b7/attachment.html>