[LLVMdev] Unit test patch, updated

[Misha Brukman]

2008/12/30 Talin <viridia at gmail.com>

> Here's the version of the unit test patch, incorporating the feedback I
> have received so far.
>

Looks good, a few comments below.


> Some notes on the patch:
>
>    - This patch doesn't include googletest itself, that will need to be
>    checked in separately. The source distribution will live in
>    llvm/utils/unittest/googletest. (The reason for the extra directory level is
>    so that the LLVM-specific makefiles can live in llvm/utils/unittest, while
>    the googletest directory itself can be the pristine, unmodified
>    distribution.)
>
> Are you going to send a separate patch for this, or should I do this?

>
>    -
>    - The individual tests are in llvm/unittests (note plural).
>    - The makefile target to build and run the tests is "make unittest" (I
>    wasn't sure if you could have a synthetic target that was the same as the
>    name of a directory, so I made it "unittest" instead of "unittests")
>
> I don't think that's an issue -- to recurse into a directory, you have to
say "make -C dir [target]".

>
>    -
>    - There's a common Makefile and a common TestMain.cpp in
>    llvm/unittests. The individual tests are in llvm/unittests/<dir> where <dir>
>    is the name of an LLVM library such as "ADT". Each of these subdirs has a
>    tiny makefile which sets TESTNAME=<name> and then includes the common
>    Makefile.unittest. Each subdir under unittests creates a separate
>    executable. (I didn't use the default googletest main because I figured at
>    some point we might want to customize main().)
>    - I updated the LICENSE.txt and mkpatch, but I haven't done the HTML
>    docs yet because I am still thinking about what to write.
>    - I probably made some mistakes in setting up the makefile rules - that
>    is what took the most time - so it will merit heightened scrutiny.
>
>
+++ unittests/Makefile.unittest    (revision 0)
[...]
+VPATH=$(PROJ_SRC_DIR) $(PROJ_SRC_ROOT)/unittests

That doesn't look like a valid path to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20081230/1702d213/attachment.html>