[LLVMdev] [PATH] Add sub.ovf/mul.ovf intrinsics

[Eli Friedman]

On Tue, Dec 9, 2008 at 1:12 PM, Zoltan Varga <vargaz at gmail.com> wrote:
> Hi,
>
>  Attached is the final version of the patch, adding the requested
> FIXME. If this is ok, can
> somebody check it in ?

Just a possible issue from inspection: does this handle 64-bit
operations correctly on x86?  Unless I'm missing something, it seems
likely to lead to a mysterious error for such operations.

Also, does DAGCombiner know not to touch operations with a known user
of the non-primary return value?  This seems like it could lead to
strange code in some cases, and it seems likely to be the cause of the
crash Zoltan mentioned... would it be better to use target-specific
nodes for the calculation?

-Eli