[LLVMdev] [PATCH]: Add SparseBitmap implementation

Daniel Berlin dberlin at dberlin.org
Wed Sep 5 20:17:02 PDT 2007


On 9/4/07, Devang Patel <dpatel at apple.com> wrote:
>
>
> On Sep 4, 2007, at 4:36 PM, Daniel Berlin wrote:
>
>
> Also, someone on IRC asked about the weird function naming
>
> conventions.  I know most of llvm uses mixedCase, but i copied the
>
> style of BitVector, which has a weird mix.  I'm happy to change it :)
> Yes please.

Fixed.

> By default, it is a good idea to follow llvm coding conventions
> instead of copying violation of coding style from existing code. Otherwise
> it pollutes code and, in future, gives someone one additional reason to not
> follow preferred coding style  :) While you're here please fix BitVector
> also.

I'll do that in a followup patch, since BitVector has a bunch of users.



More information about the llvm-dev mailing list