[LLVMdev] Linux/ppc backend

Chris Lattner sabre at nondot.org
Sat Feb 24 21:57:12 PST 2007


On Sat, 17 Feb 2007, Nicolas Geoffray wrote:
> Alright, thx Evan, that's what I did.
>
> Here are the final patches I think can be committed. I tried to separate 
> them into independent chunks, but I'm not sure how to do this in a good 
> way because of CVS and since everything is kind of related.

Sorry for the delay,

I applied the patches after some cleanups.  Please keep code within 80 
columns, please don't use nested ?: expressions without parens, and please 
be careful about indentation.  Please verify that mainline CVS has 
everything you think it should.

The one hunk I didn't apply was this one:

@@ -1392,12 +1418,13 @@
      case MVT::f32:
      case MVT::f64:
-      if (isVarArg && isPPC64) {
+      if (isVarArg || isPPC64) {
          // Float varargs need to be promoted to double.
          if (Arg.getValueType() == MVT::f32)
            Arg = DAG.getNode(ISD::FP_EXTEND, MVT::f64, Arg);

This changes the darwin/ppc ABI.  It's not clear to me that this was 
intended, so I just left it out.

Thanks a lot for these patches.  How well does linux/ppc work now?

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/



More information about the llvm-dev mailing list