[LLVMdev] RFC: GLIBCXX_DEBUG ScheduleDAG Patch

Chris Lattner sabre at nondot.org
Mon Dec 17 17:48:43 PST 2007


On Mon, 17 Dec 2007, David Greene wrote:
> On Monday 17 December 2007 13:39, Evan Cheng wrote:
>> My only concern is the potential compile time impact. Do you see any?
> I don't notice any, but then I'm not particularly looking for that either.
> I'll run some tests.

Thanks.  5% slowdowns are generally not noticable, but we care :)

> I also accidentally included some debugging code I added to track
> down this prioritization problem (the queue dumping code).  I'll remove
> that before I commit the change.
>
> I'll wait for Chris' comments re: licensing.

Re licensing, we have no problem slurping in boost code.  Please do make 
it follow the LLVM standards (80 cols and a doxygen comment above each 
class saying what it is for).  For an example of how to do the license, 
see include/llvm/ADT/scoped_ptr.h.

Thanks for finding these bugs David!

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/



More information about the llvm-dev mailing list