[LLVMdev] RFC: Patch for CFA on Darwin

Bill Wendling isanbard at gmail.com
Wed Aug 22 17:34:46 PDT 2007


On 8/22/07, Anton Korobeynikov <asl at math.spbu.ru> wrote:
> Hello, Bill
>
> > The reason for it: when going to calculate the CFA in LLVM, the
> > original code was adding an offset of type i32 to a pointer. This is
> > fine if pointers are 32-bits, but we get an assert if the types are
> > different. By converting the cfa_offset to a pointer, we get it to be
> > that size.
> How do you like the one attached? It seems to be much more clear to fix
> codegen :) Only slightly tested. If this looks ok to you - I'll commit
> tomorrow.
>
Hi Anton,

One question, can the offset be >32-bit? If not, then this patch looks
good (though I haven't tested it yet). But if the offset can be
>32-bit, then we'll have trouble with the offset being truncated in
the front-end...

-bw



More information about the llvm-dev mailing list