[LLVMdev] [patch] arm: external weak in constant pool

[Chris Lattner]

On Wed, 20 Dec 2006, Lauro Ramos Venancio wrote:
> without tabs

Looks great, applied:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061218/041706.html

Thanks,

-Chris

> 2006/12/20, Bill Wendling <isanbard at gmail.com>:
>> 
>>  Hi Lauro,
>> 
>>  Just a stylistic remark; In your "llvm.patch" file, there are tabs in
>>  these lines:
>> 
>>  +       if (GV->hasExternalWeakLinkage()) {
>>  +         ExtWeakSymbols.insert(GV);
>>  +       }
>> 
>>  Others will need to review the patch for correctness, though.
>> 
>>  -bw
>> 
>>  On 12/20/06, Lauro Ramos Venancio <lauro.venancio at gmail.com> wrote:
>> >  Adds external weak symbols of constant pool to ExtWeakSymbols set.
>> > 
>> > 
>> >  Lauro
>> > 
>> >  _______________________________________________
>> >  LLVM Developers mailing list
>> >  LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> >  http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>> > 
>> > 
>> > 
>> > 
>>  _______________________________________________
>>  LLVM Developers mailing list
>>  LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>  http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>> 
>
>

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/