[LLVMdev] [patch] move ExtWeakSymbols to AsmPrinter

Chris Lattner sabre at nondot.org
Sun Dec 10 13:51:59 PST 2006


On Sat, 9 Dec 2006, [UTF-8] Rafael Esp?ndola wrote:
> The attached patch moves the ExtWeakSymbols to the AsmPrinter class
> and the code that emits the ".weak" directives to
> AsmPrinter::doFinalization.
>
> This is just code factoring. No functionality changes.

Looks good, one request though: if practical, it would be nice to switch 
this to be set<GlobalValue*> instead of set<std::string>.

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/



More information about the llvm-dev mailing list