[LLVMdev] allocation_order_begin takes non-const reference for MachineFunction

Chris Lattner sabre at nondot.org
Thu Aug 17 15:13:24 PDT 2006


On Thu, 17 Aug 2006, Anton Vayvod wrote:
> Thanks, Ralph, this line worked well :)
> Here it is, my first patch to LLVM :)

> I've changed all allocation_order_begin() and allocation_order_end() methods
> to take const MachineFunction &MF as a parameter. I also added const version
> of MachineFunction::getInfo<Ty>() method. And I changed three static hasFP()
> functions to take const reference to MachineFunction.

Looks great, applied:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036832.html
...
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036839.html

> While doing this I've found that some methods of MachineFunction are const
> but return non-const pointers to MachineFunction internal info. Is that all
> right?

Which ones specifically?

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/



More information about the llvm-dev mailing list