[LLVMdev] Add ability for external projects use for buildinstalled version LLVM [PATCH]

[Reid Spencer]

Vladimir,

I took a *very quick* look at your patch. I won't be able to look at it in more 
detail until this weekend, but perhaps you can address a couple of concerns:

1. I don't understand the need for LLVMToolDirSlash. This seems like a
    gratuitous change to me.
2. I don't think the change to CPP.Flags is right. It won't find the LLVM
    header files
3. Removing the .PRECIOUS line will interfere with correct operation of
    parallel (make -j N) builds.
4. I don't understand why LLVMUsedLibs and other variables should only be
    set if LLVMLibDir is defined.

Before this change is committed, you need to test that all our scenarios, in 
each combination:

1. Both with and without OBJ_DIR == SRC_DIR
2. Single and Parallel builds
3. Building LLVM versus building a project (and now building from installed)

Reid.

Vladimir Merzliakov wrote:

>>> Patch attached.
>>>
>>> This patch with header installation patch ( 
>>> http://mail.cs.uiuc.edu/pipermail/llvmdev/2005-February/003300.html )
>>> let external project (I am test it at my YAFL frontend for LLVM) 
>>> build using installed LLVM version instead using LLVM obj/src dirs.
>>
>>
>> I think the patch looks basically sane.  The one wierd thing I notice 
>> is the replacement of mklib with libtool.
> 
> Ops...  I must be more careful. Updated patch attached.
> 
> I use for build libtool "ltmain.sh (GNU libtool) 1.5.10" without problems.
> But I add code to preserve use $(LLVM_OBJ_ROOT)/mklib if LLVM_OBJ_ROOT set
> In other cases if $(LLVM_OBJ_ROOT)/mklib using important it installation 
> can be added to LLVM/PROJ install process
> 
>> However, this is definitely something Reid should review.  I think 
>> he's currently out of town but will be back next week.
> 
> Waiting... :)
> 
> Vladimir
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev