[LLVMdev] Files to lib/System/Win32

[Reid Spencer]

Patch looks good so I committed it. I'd be interested in knowing what
your test results are once you start testing with the Win32 port.

Reid.

On Sat, 2004-09-18 at 12:01, Jeff Cohen wrote:
> Here's my first take on Path.cpp.  It has a few holes still but it ought
> to be basically functional.
> 
> A few observations:
> 
> First, the Win32 version still has a lot of code in common with Unix. 
> This code should be pulled out into a common file.
> 
> Second, some of the functions leave me scratching me head.  What purpose
> does create_file serve?  Is there really a need to create empty files?
> (It also leaks an open file handle, BTW).  I would expect set_file to
> alter only the file name portion of the path and leave the directory
> portion unchanged, and the opposite for set_directory.  set_directory
> obliterates the file name portion of the path (OK, I guess) but set_file
> doesn't make any sense at all.
> 
> ______________________________________________________________________
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040918/d6ee44b0/attachment.sig>