[LLVMdev] small patch for llvm configure.ac

[Reid Spencer]

On Wed, 2004-12-22 at 22:38, Markus F.X.J. Oberhumer wrote:
> Hello Reid,
> 
> > > @@ -167,7 +168,7 @@
> > >  if test ${enableval} = "no" ; then
> > >    AC_SUBST(ENABLE_OPTIMIZED,[[]])
> > >  else
> > > -  AC_SUBST(ENABLE_OPTIMIZED,[[ENABLE_OPTIMIZED=1]])
> > > +  AC_SUBST(ENABLE_OPTIMIZED,[[1]])
> >
> > This is not okay, at least not without other changes. We do some weird
> > things in Makefile.config.in where these values are used that I've been
> > meaning to clean up so that the "correct" usage you show above is used.
> > However, until those changes are made, I can't commit this because it
> > will break the LLVM makefile system.
> 
> Please note that this expands to "ENABLE_OPTIMIZED=ENABLE_OPTIMIZED=1".
> Is this eval'ed somewhere ?

We use it like this:

@ENABLE_OPTIMZED@

in a makefile so it expands to a line of:

ENABLE_OPTIMIZED=1

Weird, I know, but it works. The point is, we don't want the makefile
variable even defined if it has no value so this strategy works.

> Again, this expands to "JIT=TARGET_HAS_JIT=1", and I've grepped over
> the llvm source tree and found that "TARGET_HAS_JIT" is never used ??

Same usage in the makefiles as described above.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041223/88fe001f/attachment.sig>