[llvm] [InstCombine] fold ((X + C) & ~C) - X -> X & C where C is a power of 2 (PR #230796)
Andreas Jonson via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 11 03:45:06 PDT 2026
https://github.com/andjo403 updated https://github.com/llvm/llvm-project/pull/230796
>From b7d77b66c9dca9eb198ecd0b4b1c30b44dc30a3b Mon Sep 17 00:00:00 2001
From: Andreas Jonson <andjo403 at hotmail.com>
Date: Sat, 10 Oct 2026 16:20:36 +0200
Subject: [PATCH 1/3] [InstCombine] Pre commit test (NFC)
---
llvm/test/Transforms/InstCombine/sub.ll | 82 +++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/llvm/test/Transforms/InstCombine/sub.ll b/llvm/test/Transforms/InstCombine/sub.ll
index 1e7fa477c362c..437920fcdf895 100644
--- a/llvm/test/Transforms/InstCombine/sub.ll
+++ b/llvm/test/Transforms/InstCombine/sub.ll
@@ -2948,3 +2948,85 @@ define i32 @sub_const_or_no_disjoint(i32 %x) {
%r = sub i32 100, %a
ret i32 %r
}
+
+define i8 @sub_and_add(i8 %x) {
+; CHECK-LABEL: @sub_and_add(
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 1
+; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -2
+; CHECK-NEXT: [[RET:%.*]] = sub i8 [[AND]], [[X]]
+; CHECK-NEXT: ret i8 [[RET]]
+;
+ %add = add i8 %x, 1
+ %and = and i8 %add, -2
+ %ret = sub i8 %and, %x
+ ret i8 %ret
+}
+
+define i8 @sub_and_add_multi_use(i8 %x) {
+; CHECK-LABEL: @sub_and_add_multi_use(
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 2
+; CHECK-NEXT: call void @use8(i8 [[ADD]])
+; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -3
+; CHECK-NEXT: call void @use8(i8 [[AND]])
+; CHECK-NEXT: [[RET:%.*]] = sub i8 [[AND]], [[X]]
+; CHECK-NEXT: ret i8 [[RET]]
+;
+ %add = add i8 %x, 2
+ call void @use8(i8 %add)
+ %and = and i8 %add, -3
+ call void @use8(i8 %and)
+ %ret = sub i8 %and, %x
+ ret i8 %ret
+}
+
+define <2 x i8> @sub_and_add_vec(<2 x i8> %x) {
+; CHECK-LABEL: @sub_and_add_vec(
+; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X:%.*]], splat (i8 1)
+; CHECK-NEXT: [[AND:%.*]] = and <2 x i8> [[ADD]], splat (i8 -2)
+; CHECK-NEXT: [[RET:%.*]] = sub <2 x i8> [[AND]], [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RET]]
+;
+ %add = add <2 x i8> %x, <i8 1, i8 1>
+ %and = and <2 x i8> %add, <i8 -2, i8 -2>
+ %ret = sub <2 x i8> %and, %x
+ ret <2 x i8> %ret
+}
+
+define i8 @neg_sub_and_add_commuted(i8 %x) {
+; CHECK-LABEL: @neg_sub_and_add_commuted(
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 1
+; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -2
+; CHECK-NEXT: [[RET:%.*]] = sub i8 [[X]], [[AND]]
+; CHECK-NEXT: ret i8 [[RET]]
+;
+ %add = add i8 %x, 1
+ %and = and i8 %add, -2
+ %ret = sub i8 %x, %and
+ ret i8 %ret
+}
+
+define i8 @neg_sub_and_add_2(i8 %x) {
+; CHECK-LABEL: @neg_sub_and_add_2(
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 3
+; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -2
+; CHECK-NEXT: [[RET:%.*]] = sub i8 [[AND]], [[X]]
+; CHECK-NEXT: ret i8 [[RET]]
+;
+ %add = add i8 %x, 3
+ %and = and i8 %add, -2
+ %ret = sub i8 %and, %x
+ ret i8 %ret
+}
+
+define i8 @neg_sub_and_-4_add(i8 %x) {
+; CHECK-LABEL: @neg_sub_and_-4_add(
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 1
+; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -4
+; CHECK-NEXT: [[RET:%.*]] = add i8 [[AND]], [[X]]
+; CHECK-NEXT: ret i8 [[RET]]
+;
+ %add = add i8 %x, 1
+ %and = and i8 %add, -4
+ %ret = add i8 %and, %x
+ ret i8 %ret
+}
>From 8ac2d5b904f5caa4752d569bd9ed8488421acdc5 Mon Sep 17 00:00:00 2001
From: Andreas Jonson <andjo403 at hotmail.com>
Date: Sat, 10 Oct 2026 16:23:27 +0200
Subject: [PATCH 2/3] [InstCombine] fold sub (and (add x, pow2), ~pow2), x ->
and x, pow2
---
llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp | 4 ++++
llvm/test/Transforms/InstCombine/sub.ll | 10 +++-------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
index 3ebcbe44c4c3d..53fb2b65122ca 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
@@ -3103,6 +3103,10 @@ Instruction *InstCombinerImpl::visitSub(BinaryOperator &I) {
}
}
}
+ if (match(Op0, m_And(m_Add(m_Value(X), m_Power2(AddC)), m_APInt(AndC))) &&
+ X == Op1 && *AddC == ~*AndC) {
+ return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, *AddC));
+ }
return TryToNarrowDeduceFlags();
}
diff --git a/llvm/test/Transforms/InstCombine/sub.ll b/llvm/test/Transforms/InstCombine/sub.ll
index 437920fcdf895..5b254d31abd1d 100644
--- a/llvm/test/Transforms/InstCombine/sub.ll
+++ b/llvm/test/Transforms/InstCombine/sub.ll
@@ -2951,9 +2951,7 @@ define i32 @sub_const_or_no_disjoint(i32 %x) {
define i8 @sub_and_add(i8 %x) {
; CHECK-LABEL: @sub_and_add(
-; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X:%.*]], 1
-; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -2
-; CHECK-NEXT: [[RET:%.*]] = sub i8 [[AND]], [[X]]
+; CHECK-NEXT: [[RET:%.*]] = and i8 [[X:%.*]], 1
; CHECK-NEXT: ret i8 [[RET]]
;
%add = add i8 %x, 1
@@ -2968,7 +2966,7 @@ define i8 @sub_and_add_multi_use(i8 %x) {
; CHECK-NEXT: call void @use8(i8 [[ADD]])
; CHECK-NEXT: [[AND:%.*]] = and i8 [[ADD]], -3
; CHECK-NEXT: call void @use8(i8 [[AND]])
-; CHECK-NEXT: [[RET:%.*]] = sub i8 [[AND]], [[X]]
+; CHECK-NEXT: [[RET:%.*]] = and i8 [[X]], 2
; CHECK-NEXT: ret i8 [[RET]]
;
%add = add i8 %x, 2
@@ -2981,9 +2979,7 @@ define i8 @sub_and_add_multi_use(i8 %x) {
define <2 x i8> @sub_and_add_vec(<2 x i8> %x) {
; CHECK-LABEL: @sub_and_add_vec(
-; CHECK-NEXT: [[ADD:%.*]] = add <2 x i8> [[X:%.*]], splat (i8 1)
-; CHECK-NEXT: [[AND:%.*]] = and <2 x i8> [[ADD]], splat (i8 -2)
-; CHECK-NEXT: [[RET:%.*]] = sub <2 x i8> [[AND]], [[X]]
+; CHECK-NEXT: [[RET:%.*]] = and <2 x i8> [[X:%.*]], splat (i8 1)
; CHECK-NEXT: ret <2 x i8> [[RET]]
;
%add = add <2 x i8> %x, <i8 1, i8 1>
>From e3e04715569a9d54c2006778be40316ccee5eaa3 Mon Sep 17 00:00:00 2001
From: Andreas Jonson <andjo403 at hotmail.com>
Date: Sat, 10 Oct 2026 19:12:19 +0200
Subject: [PATCH 3/3] fixup! [InstCombine] fold sub (and (add x, pow2), ~pow2),
x -> and x, pow2
---
llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
index 53fb2b65122ca..1b364e4f05192 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
@@ -3103,9 +3103,12 @@ Instruction *InstCombinerImpl::visitSub(BinaryOperator &I) {
}
}
}
- if (match(Op0, m_And(m_Add(m_Value(X), m_Power2(AddC)), m_APInt(AndC))) &&
- X == Op1 && *AddC == ~*AndC) {
- return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, *AddC));
+
+ // ((X + C) & ~C) - X -> X & C where C is a power of 2.
+ if (match(Op0,
+ m_And(m_Add(m_Specific(Op1), m_Power2(AddC)), m_APInt(AndC))) &&
+ *AddC == ~*AndC) {
+ return BinaryOperator::CreateAnd(Op1, ConstantInt::get(Ty, *AddC));
}
return TryToNarrowDeduceFlags();
More information about the llvm-commits
mailing list