[llvm] [GlobalISel] Ensure integer trunc and anyext in call lowering. (PR #229346)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 6 02:02:29 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-webassembly
Author: David Green (davemgreen)
<details>
<summary>Changes</summary>
This ensures that the trunc and anyext created for argument lowering have integer types, possibly casting back to fp types. This helps the Arm backend but also comes up for WebAssembly and AMDGPU too.
---
Full diff: https://github.com/llvm/llvm-project/pull/229346.diff
5 Files Affected:
- (modified) llvm/lib/CodeGen/GlobalISel/CallLowering.cpp (+21-2)
- (modified) llvm/test/CodeGen/Generic/GlobalISel/irtranslator-byte-type.ll (+2-1)
- (modified) llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/args.ll (+2-1)
- (modified) llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/call-basics.ll (+8-4)
- (modified) llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/ret-basics.ll (+2-1)
``````````diff
diff --git a/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp b/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
index 4d97001eb7420..d56d7f59bb4d0 100644
--- a/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -460,7 +460,13 @@ void CallLowering::buildCopyFromRegs(MachineIRBuilder &B,
return;
}
- B.buildTrunc(OrigRegs[0], SrcReg);
+ LLT OrigITy = OrigTy.changeToInteger();
+ if (OrigTy == OrigITy) {
+ B.buildTrunc(OrigRegs[0], SrcReg);
+ } else {
+ auto Trunc = B.buildTrunc(OrigITy, SrcReg);
+ B.buildBitcast(OrigRegs[0], Trunc);
+ }
return;
}
@@ -613,7 +619,20 @@ void CallLowering::buildCopyToRegs(MachineIRBuilder &B,
if (PartTy.isVector() == SrcTy.isVector() &&
PartTy.getScalarSizeInBits() > SrcTy.getScalarSizeInBits()) {
assert(DstRegs.size() == 1);
- B.buildInstr(ExtendOp, {DstRegs[0]}, {SrcReg});
+ // Convert float to integer if needed
+ LLT SrcITy = SrcTy.changeToInteger();
+ LLT PartITy = PartTy.changeToInteger();
+ if (SrcTy != SrcITy)
+ SrcReg = B.buildBitcast(SrcITy, SrcReg).getReg(0);
+ // Emit the sext/zext/anyext
+ Register DstIReg =
+ B.buildInstr(ExtendOp,
+ PartITy == PartTy ? DstOp(DstRegs[0]) : DstOp(PartITy),
+ {SrcReg})
+ .getReg(0);
+ // Convert back to the original type if needed
+ if (PartITy != PartTy)
+ B.buildBitcast(DstRegs[0], DstIReg);
return;
}
diff --git a/llvm/test/CodeGen/Generic/GlobalISel/irtranslator-byte-type.ll b/llvm/test/CodeGen/Generic/GlobalISel/irtranslator-byte-type.ll
index 9d91ff55d6916..e291dbac1f61a 100644
--- a/llvm/test/CodeGen/Generic/GlobalISel/irtranslator-byte-type.ll
+++ b/llvm/test/CodeGen/Generic/GlobalISel/irtranslator-byte-type.ll
@@ -778,7 +778,8 @@ define half @bytecast_b16_to_half(b16 %b) {
; AMDGPU-NEXT: [[COPY:%[0-9]+]]:_(i32) = COPY $vgpr0
; AMDGPU-NEXT: [[TRUNC:%[0-9]+]]:_(i16) = G_TRUNC [[COPY]](i32)
; AMDGPU-NEXT: [[BITCAST:%[0-9]+]]:_(f16) = G_BITCAST [[TRUNC]](i16)
- ; AMDGPU-NEXT: [[ANYEXT:%[0-9]+]]:_(i32) = G_ANYEXT [[BITCAST]](f16)
+ ; AMDGPU-NEXT: [[BITCAST1:%[0-9]+]]:_(i16) = G_BITCAST [[BITCAST]](f16)
+ ; AMDGPU-NEXT: [[ANYEXT:%[0-9]+]]:_(i32) = G_ANYEXT [[BITCAST1]](i16)
; AMDGPU-NEXT: $vgpr0 = COPY [[ANYEXT]](i32)
; AMDGPU-NEXT: SI_RETURN implicit $vgpr0
;
diff --git a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/args.ll b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/args.ll
index 97413111536be..0a865072f2443 100644
--- a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/args.ll
+++ b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/args.ll
@@ -105,7 +105,8 @@ define void @test_f16_arg(half %arg) {
; CHECK-NEXT: liveins: $arguments
; CHECK-NEXT: {{ $}}
; CHECK-NEXT: [[ARGUMENT_i32_:%[0-9]+]]:i32(i32) = ARGUMENT_i32 0, implicit $arguments
- ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(f16) = G_TRUNC [[ARGUMENT_i32_]](i32)
+ ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(i16) = G_TRUNC [[ARGUMENT_i32_]](i32)
+ ; CHECK-NEXT: [[BITCAST:%[0-9]+]]:_(f16) = G_BITCAST [[TRUNC]](i16)
; CHECK-NEXT: RETURN implicit-def $arguments
ret void
}
diff --git a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/call-basics.ll b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/call-basics.ll
index 5a1a4fc8f3c68..5b6150500fe2e 100644
--- a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/call-basics.ll
+++ b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/call-basics.ll
@@ -132,8 +132,10 @@ define half @call_ret_f16_args_none() {
; CHECK-NEXT: liveins: $arguments
; CHECK-NEXT: {{ $}}
; CHECK-NEXT: [[CALL:%[0-9]+]]:i32(i32) = CALL @ret_f16_args_none, implicit-def $arguments, implicit $sp32, implicit $sp64
- ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(f16) = G_TRUNC [[CALL]](i32)
- ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[TRUNC]](f16)
+ ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(i16) = G_TRUNC [[CALL]](i32)
+ ; CHECK-NEXT: [[BITCAST:%[0-9]+]]:_(f16) = G_BITCAST [[TRUNC]](i16)
+ ; CHECK-NEXT: [[BITCAST1:%[0-9]+]]:_(i16) = G_BITCAST [[BITCAST]](f16)
+ ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[BITCAST1]](i16)
; CHECK-NEXT: RETURN [[ANYEXT]](i32), implicit-def $arguments
%ret = call half @ret_f16_args_none()
ret half %ret
@@ -239,8 +241,10 @@ define void @call_ret_void_args_f16(half %a) {
; CHECK-NEXT: liveins: $arguments
; CHECK-NEXT: {{ $}}
; CHECK-NEXT: [[ARGUMENT_i32_:%[0-9]+]]:i32(i32) = ARGUMENT_i32 0, implicit $arguments
- ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(f16) = G_TRUNC [[ARGUMENT_i32_]](i32)
- ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[TRUNC]](f16)
+ ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:_(i16) = G_TRUNC [[ARGUMENT_i32_]](i32)
+ ; CHECK-NEXT: [[BITCAST:%[0-9]+]]:_(f16) = G_BITCAST [[TRUNC]](i16)
+ ; CHECK-NEXT: [[BITCAST1:%[0-9]+]]:_(i16) = G_BITCAST [[BITCAST]](f16)
+ ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[BITCAST1]](i16)
; CHECK-NEXT: CALL @ret_void_args_f16, [[ANYEXT]](i32), implicit-def $arguments, implicit $sp32, implicit $sp64
; CHECK-NEXT: RETURN implicit-def $arguments
call void @ret_void_args_f16(half %a)
diff --git a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/ret-basics.ll b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/ret-basics.ll
index 3bc6aaaa3d48c..d3698e3bb98d1 100644
--- a/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/ret-basics.ll
+++ b/llvm/test/CodeGen/WebAssembly/GlobalISel/irtranslator/ret-basics.ll
@@ -99,7 +99,8 @@ define half @test_ret_f16() {
; CHECK-NEXT: liveins: $arguments
; CHECK-NEXT: {{ $}}
; CHECK-NEXT: [[C:%[0-9]+]]:_(f16) = G_FCONSTANT half 0.000000e+00
- ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[C]](f16)
+ ; CHECK-NEXT: [[C1:%[0-9]+]]:_(i16) = G_CONSTANT i16 0
+ ; CHECK-NEXT: [[ANYEXT:%[0-9]+]]:i32(i32) = G_ANYEXT [[C1]](i16)
; CHECK-NEXT: RETURN [[ANYEXT]](i32), implicit-def $arguments
ret half 0.0
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/229346
More information about the llvm-commits
mailing list