[llvm] [SPIRV] Only emit MaxByteOffset decoration for SPIR-V 1.1 or later (PR #228973)

Alexander Shaposhnikov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 03:02:43 PDT 2026


https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/228973

>From 2f532647202cb5493e0036b0c9298159cf95bb5e Mon Sep 17 00:00:00 2001
From: Alexander Shaposhnikov <alexander.v.shaposhnikov at gmail.com>
Date: Mon, 5 Oct 2026 02:50:43 -0700
Subject: [PATCH] [SPIRV] Only emit MaxByteOffset decoration for SPIR-V 1.1 or
 later

The MaxByteOffset decoration was introduced in SPIR-V 1.1.
Guard the MaxByteOffset decoration emission in lowerFormalArguments with version check, matching SPIRV-LLVM-Translator behavior.
---
 llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp   |  4 ++--
 .../lib/Target/SPIRV/SPIRVSymbolicOperands.td |  2 +-
 .../DecorationMaxByteOffset-shader.ll         | 22 +++++++++++++++++++
 .../transcoding/DecorationMaxByteOffset.ll    |  9 ++++++++
 4 files changed, 34 insertions(+), 3 deletions(-)
 create mode 100644 llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset-shader.ll

diff --git a/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp b/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp
index 330704d0f88577..06b93fbf0ed472 100644
--- a/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp
@@ -266,9 +266,9 @@ bool SPIRVCallLowering::lowerFormalArguments(MachineIRBuilder &MIRBuilder,
 
       if (Arg.hasName())
         buildOpName(VRegs[i][0], Arg.getName(), MIRBuilder);
-      if (isPointerTyOrWrapper(Arg.getType())) {
+      if (isPointerTyOrWrapper(Arg.getType()) && !ST->isShader()) {
         auto DerefBytes = static_cast<unsigned>(Arg.getDereferenceableBytes());
-        if (DerefBytes != 0)
+        if (DerefBytes != 0 && ST->isAtLeastSPIRVVer(VersionTuple(1, 1)))
           buildOpDecorate(VRegs[i][0], MIRBuilder,
                           SPIRV::Decoration::MaxByteOffset, {DerefBytes});
       }
diff --git a/llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td b/llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td
index 561d0fdef40264..92e81eb2697252 100644
--- a/llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td
+++ b/llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td
@@ -1406,7 +1406,7 @@ defm LinkageAttributes : DecorationOperand<41, 0, 0, [], [Linkage]>;
 defm NoContraction : DecorationOperand<42, 0, 0, [], [Shader]>;
 defm InputAttachmentIndex : DecorationOperand<43, 0, 0, [], [InputAttachment]>;
 defm Alignment : DecorationOperand<44, 0, 0, [], [Kernel]>;
-defm MaxByteOffset : DecorationOperand<45, 0, 0, [], [Addresses]>;
+defm MaxByteOffset : DecorationOperand<45, 0x10100, 0, [], [Addresses]>;
 defm AlignmentId : DecorationOperand<46, 0, 0, [], [Kernel]>;
 defm MaxByteOffsetId : DecorationOperand<47, 0, 0, [], [Addresses]>;
 defm NoSignedWrap : DecorationOperand<4469, 0x10400, 0, [SPV_KHR_no_integer_wrap_decoration], []>;
diff --git a/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset-shader.ll b/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset-shader.ll
new file mode 100644
index 00000000000000..3f0c53b89f7a76
--- /dev/null
+++ b/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset-shader.ll
@@ -0,0 +1,22 @@
+; RUN: llc -O0 -mtriple=spirv-unknown-vulkan1.3-compute %s -o - | FileCheck %s --implicit-check-not=MaxByteOffset --implicit-check-not="OpCapability Addresses"
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-vulkan1.3-compute %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
+
+; MaxByteOffset requires Addresses, which is not available for shader targets.
+; CHECK: OpCapability Shader
+; CHECK: OpName %[[#PTR:]] "ptr"
+; CHECK: %[[#INT:]] = OpTypeInt 32 0
+; CHECK: %[[#PTR_T:]] = OpTypePointer Function %[[#INT]]
+; CHECK: %[[#PTR]] = OpFunctionParameter %[[#PTR_T]]
+
+define internal void @helper(ptr dereferenceable(4) %ptr) noinline {
+  store i32 1, ptr %ptr, align 4
+  ret void
+}
+
+define void @main() #0 {
+  %ptr = alloca i32, align 4
+  call void @helper(ptr %ptr)
+  ret void
+}
+
+attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
diff --git a/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset.ll b/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset.ll
index fec55c5c89a713..f1edbed8d66014 100644
--- a/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset.ll
+++ b/llvm/test/CodeGen/SPIRV/transcoding/DecorationMaxByteOffset.ll
@@ -1,5 +1,11 @@
 ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; RUN: llc -O0 -mtriple=spirv64v1.1-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64v1.1-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env spv1.1 %}
+; RUN: llc -O0 -mtriple=spirv32v1.0-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV_1_0
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32v1.0-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env spv1.0 %}
+; RUN: llc -O0 -mtriple=spirv64v1.0-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV_1_0
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64v1.0-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env spv1.0 %}
 
 ; CHECK-SPIRV:     OpName %[[#PTR_ID:]] "ptr"
 ; CHECK-SPIRV:     OpName %[[#PTR2_ID:]] "ptr2"
@@ -10,6 +16,9 @@
 ; CHECK-SPIRV:     %[[#PTR_ID]] = OpFunctionParameter %[[#CHAR_PTR_T]]
 ; CHECK-SPIRV:     %[[#PTR2_ID]] = OpFunctionParameter %[[#CHAR_PTR_T]]
 
+; CHECK-SPIRV_1_0-NOT: MaxByteOffset
+; CHECK-SPIRV_1_0:     OpFunctionParameter
+
 define spir_kernel void @worker(ptr addrspace(3) dereferenceable(12) %ptr) {
 entry:
   %ptr.addr = alloca ptr addrspace(3), align 4



More information about the llvm-commits mailing list