[llvm] CodeGen: Prefer getting the Triple from the Module (PR #228682)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/TargetInstrInfo.cpp.obj</summary>

```
FAILED: [code=1] lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/TargetInstrInfo.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\lib\CodeGen -IC:\_work\llvm-project\llvm-project\llvm\lib\CodeGen -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro /EHs-c- /GR- /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\TargetInstrInfo.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb -c -- C:\_work\llvm-project\llvm-project\llvm\lib\CodeGen\TargetInstrInfo.cpp
C:\_work\llvm-project\llvm-project\llvm\lib\CodeGen\TargetInstrInfo.cpp(483,41): error: member access into incomplete type 'Module'
483 |           (!MF.getFunction().getParent()->getTargetTriple().isOSDarwin() &&
|                                         ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Analysis.h(21,7): note: forward declaration of 'llvm::Module'
21 | class Module;
|       ^
1 error generated.
```
</details>
<details>
<summary>[code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64FrameLowering.cpp.obj</summary>

```
FAILED: [code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64FrameLowering.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro /EHs-c- /GR- /showIncludes /Folib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\AArch64FrameLowering.cpp.obj /Fdlib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\LLVMAArch64CodeGen.pdb -c -- C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64FrameLowering.cpp
C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64FrameLowering.cpp(634,50): error: member access into incomplete type 'const Module'
634 |   const Triple &TT = MF.getFunction().getParent()->getTargetTriple();
|                                                  ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Analysis.h(21,7): note: forward declaration of 'llvm::Module'
21 | class Module;
|       ^
1 error generated.
```
</details>
<details>
<summary>[code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64PointerAuth.cpp.obj</summary>

```
FAILED: [code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64PointerAuth.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro /EHs-c- /GR- /showIncludes /Folib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\AArch64PointerAuth.cpp.obj /Fdlib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\LLVMAArch64CodeGen.pdb -c -- C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64PointerAuth.cpp
C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64PointerAuth.cpp(138,50): error: member access into incomplete type 'Module'
138 |   const Triple &TT = MF.getFunction().getParent()->getTargetTriple();
|                                                  ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Analysis.h(21,7): note: forward declaration of 'llvm::Module'
21 | class Module;
|       ^
C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64PointerAuth.cpp(180,50): error: member access into incomplete type 'Module'
180 |   const Triple &TT = MF.getFunction().getParent()->getTargetTriple();
|                                                  ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Analysis.h(21,7): note: forward declaration of 'llvm::Module'
21 | class Module;
|       ^
2 errors generated.
```
</details>
<details>
<summary>[code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64MCInstLower.cpp.obj</summary>

```
FAILED: [code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64MCInstLower.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64 -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro /EHs-c- /GR- /showIncludes /Folib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\AArch64MCInstLower.cpp.obj /Fdlib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\LLVMAArch64CodeGen.pdb -c -- C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64MCInstLower.cpp
C:\_work\llvm-project\llvm-project\llvm\lib\Target\AArch64\AArch64MCInstLower.cpp(48,44): error: member access into incomplete type 'const Module'
48 |   const Triple &TheTriple = GV->getParent()->getTargetTriple();
|                                            ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Value.h(49,7): note: forward declaration of 'llvm::Module'
49 | class Module;
|       ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/228682