[llvm] [lldb][bazel] Remove stale Bazel deps (PR #228580)

via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 13:49:48 PDT 2026


https://github.com/lexi-nadia created https://github.com/llvm/llvm-project/pull/228580

- Core's dependency on PluginCPlusPlusLanguageHeaders and PluginObjCLanguageHeaders was removed in 897cc3ee429a62e1dfd77a602db96e9884671f93.
- Expression's dependency on PluginSymbolFileDWARFHeaders was removed in 59c5d531991ca6d3cdd7072a13331dd5b0a5b321.
- Interpreter's dependency on API was removed in ed3d4a78ba8b23ab5d3fb629029695a03818d254.

These edges made LLDB core libraries transitively depend on plugins (and, through :API, on every default plugin). The build passes with layering_check after removing them.

>From 69f545df13c6fd0cdbc8a250367fb251a647b37d Mon Sep 17 00:00:00 2001
From: Lexi Bromfield <lexinadia at google.com>
Date: Thu, 1 Oct 2026 22:59:25 +0000
Subject: [PATCH] [lldb][bazel] Remove stale Bazel deps

- Core's dependency on PluginCPlusPlusLanguageHeaders and
  PluginObjCLanguageHeaders was removed in
  897cc3ee429a62e1dfd77a602db96e9884671f93.
- Expression's dependency on PluginSymbolFileDWARFHeaders was removed in
  59c5d531991ca6d3cdd7072a13331dd5b0a5b321.
- Interpreter's dependency on API was removed in
  ed3d4a78ba8b23ab5d3fb629029695a03818d254.

These edges made LLDB core libraries transitively depend on plugins
(and, through :API, on every default plugin). The build passes with
layering_check after removing them.
---
 .../llvm-project-overlay/lldb/BUILD.bazel     | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
index f876c28c3d474..3a5a35b5c0112 100644
--- a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
@@ -250,11 +250,11 @@ cc_library(
     name = "API",
     srcs = glob([
         "source/API/**/*.cpp",
+        "source/API/**/*.h",
     ]),
     hdrs = glob(["include/lldb/API/**/*.h"]) + [":lldb-sbapi-dwarf-enums"],
     includes = ["include"],
     deps = [
-        ":APIPrivateHeaders",
         ":Breakpoint",
         ":Commands",
         ":Core",
@@ -263,6 +263,7 @@ cc_library(
         ":Headers",
         ":Host",
         ":Initialization",
+        ":Interpreter",
         ":InterpreterHeaders",
         ":Symbol",
         ":SymbolHeaders",
@@ -349,7 +350,6 @@ cc_library(
         ":SymbolHeaders",
         ":TargetHeaders",
         ":Utility",
-        "//lldb/source/Plugins:PluginSymbolFileDWARFHeaders",
         "//llvm:BinaryFormat",
         "//llvm:Core",
         "//llvm:DebugInfoDWARF",
@@ -402,23 +402,12 @@ cc_library(
     includes = ["include"],
 )
 
-cc_library(
-    name = "APIPrivateHeaders",
-    hdrs = glob(["source/API/**/*.h"]),
-    features = ["-parse_headers"],  # Would otherwise have circular dependencies
-    includes = ["source"],
-    deps = [
-        ":APIHeaders",
-    ],
-)
-
 cc_library(
     name = "InterpreterHeaders",
     hdrs = glob(["include/lldb/Interpreter/**/*.h"]),
     features = ["-parse_headers"],  # Would otherwise have circular dependencies
     includes = ["include"],
     deps = [
-        ":APIHeaders",
         ":Headers",
     ],
 )
@@ -453,8 +442,6 @@ cc_library(
     name = "Interpreter",
     srcs = glob(["source/Interpreter/**/*.cpp"]),
     deps = [
-        ":API",
-        ":APIPrivateHeaders",
         ":Commands",
         ":Core",
         ":DataFormatters",
@@ -787,8 +774,6 @@ cc_library(
         ":Utility",
         ":Version",
         "//clang:driver",
-        "//lldb/source/Plugins:PluginCPlusPlusLanguageHeaders",
-        "//lldb/source/Plugins:PluginObjCLanguageHeaders",
         "//llvm:BinaryFormat",
         "//llvm:Demangle",
         "//llvm:Support",



More information about the llvm-commits mailing list