[lld] [lld][ELF] Reject TLS relocations against non-STT_TLS symbols (PR #228418)

[Peter Smith via llvm-commits]

https://github.com/smithp35 commented:

My first reaction is that I wasn't expecting so many target specific checks. I think there are places where LLD iteratates over all the relocations and we can diagnose in one place.

We should definitely be sure not to check the same relocation multiple times.

Given we had no checking previously, I would prefer a simple check that perhaps has some missed edge-cases than so many changes across the targets. Especially as I expect the only source of errors to come from assembler authors.

https://github.com/llvm/llvm-project/pull/228418