[clang] [llvm] [SystemZ][z/OS] Open text files as text (PR #228189)

Abhina Sree via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 11:55:58 PDT 2026


abhina-sree wrote:

> I may understand this wrong, but is this change safe when the Mips/X86 test is run on non-zos host OS? I see `MemoryBuffer::getFile()` calls `getFileAux()` which has
> 
> ```
>   Expected<sys::fs::file_t> FDOrErr = sys::fs::openNativeFileForRead(
>       Filename, IsText ? sys::fs::OF_TextWithCRLF : sys::fs::OF_None);
> ```
> 
> and `sys::fs::OF_TextWithCRLF` means "in text mode with Windows-style line endings (\r\n)." Thanks!

ah I think you're right, I will close this PR if the CI check fails on Windows

https://github.com/llvm/llvm-project/pull/228189


More information about the llvm-commits mailing list