[llvm] [KnownBits] Improve minimum denominator bounds for sdiv (PR #227264)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 1 02:45:08 PDT 2026
jayfoad wrote:
> Generally a lit test showing a change in a transform is preferred to a unit test
For KnownBits I disagree, I think the unit tests are a much clearer and more direct way to test the core logic. But since you've already gone to the effort of writing the InstCombine tests I won't insist that you change back again.
> AI disclosure: No AI was used to generate or find the fix for this issue, including tests.
This is the first time I've seen a "no AI" disclosure!
https://github.com/llvm/llvm-project/pull/227264
More information about the llvm-commits
mailing list