[llvm] [DebugInfo] Accept DW_OP_xderef_size and DW_OP_lit1..DW_OP_lit31. (PR #227839)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/test/Assembler/invalid-diexpression-deref-size-operand.ll llvm/test/Assembler/invalid-diexpression-xderef-size.ll llvm/test/DebugInfo/NVPTX/debug-addr-class-lit-xderef-size.ll llvm/test/DebugInfo/X86/diexpression-lit-xderef-size.ll llvm/include/llvm/IR/DebugInfoMetadata.h llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp llvm/lib/CodeGen/PrologEpilogInserter.cpp llvm/lib/CodeGen/TargetInstrInfo.cpp llvm/lib/DebugInfo/LogicalView/Readers/LVIRReader.cpp llvm/lib/IR/DIExpressionOptimizer.cpp llvm/lib/IR/DebugInfoMetadata.cpp llvm/test/Assembler/diexpression.ll llvm/unittests/IR/MetadataTest.cpp
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/DebugInfo/NVPTX/debug-addr-class-lit-xderef-size.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/227839