[polly] 4dd9d22 - [Polly] Remove non-goal TODO (#227638)

[via llvm-commits]

Author: Michael Kruse
Date: 2026-09-30T10:19:38Z
New Revision: 4dd9d22d4f0c8da881557d5bd95ac0ce25df79f8

URL: https://github.com/llvm/llvm-project/commit/4dd9d22d4f0c8da881557d5bd95ac0ce25df79f8
DIFF: https://github.com/llvm/llvm-project/commit/4dd9d22d4f0c8da881557d5bd95ac0ce25df79f8.diff

LOG: [Polly] Remove non-goal TODO (#227638)

Apply post-commit review changes of #227545.

`%loadNPMPolly` is necessary to conditionally load the Polly plugin and
not having to repreat a lot of options in each regression test. It
cannot be spelled out in each individual test. Apply this change as
discussed in
https://github.com/llvm/llvm-project/pull/227545#discussion_r4142513423.
It could replaced with a tool substitution instead.

Also prefer use the default-sized `SmallVector` as by the LLVM
programmer's manual:
https://llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h.

Added: 
    

Modified: 
    polly/lib/Support/RegisterPasses.cpp
    polly/test/lit.site.cfg.in

Removed: 
    


################################################################################
diff  --git a/polly/lib/Support/RegisterPasses.cpp b/polly/lib/Support/RegisterPasses.cpp
index e7ca2c4672479..bd3264fb2e4b5 100644
--- a/polly/lib/Support/RegisterPasses.cpp
+++ b/polly/lib/Support/RegisterPasses.cpp
@@ -692,7 +692,7 @@ void registerPollyPasses(PassBuilder &PB) {
 } // namespace polly
 
 static Error parseArguments(ArrayRef<const char *> Args) {
-  SmallVector<const char *, 0> Argv = {"Polly"};
+  SmallVector<const char *> Argv = {"Polly"};
   append_range(Argv, Args);
   std::string Msg;
   raw_string_ostream OS(Msg);

diff  --git a/polly/test/lit.site.cfg.in b/polly/test/lit.site.cfg.in
index c6163fb806306..d808c5ff04475 100644
--- a/polly/test/lit.site.cfg.in
+++ b/polly/test/lit.site.cfg.in
@@ -27,8 +27,6 @@ for arch in config.targets_to_build.split():
 # directories.
 config.excludes = ['Inputs']
 
-# TODO: Let tests spell out -load-pass-plugin and these options, and remove
-# %loadNPMPolly.
 commonOpts = ''.join(' -plugin-arg=Polly,' + opt for opt in [
     '-polly-process-unprofitable',
     '-polly-remarks-minimal',