[polly] [Polly] Remove non-goal TODO (PR #227638)

[Michael Kruse via llvm-commits]

https://github.com/Meinersbur created https://github.com/llvm/llvm-project/pull/227638

Apply post-commit review changes of #227545.

`%loadNPMPolly` is necessary to conditionally load the Polly plugin and not having to repreat a lot of options in each regression test. It cannot be spelled out in each individual test. Apply this change as discussed in https://github.com/llvm/llvm-project/pull/227545#discussion_r4142513423.
It could replaced with a tool substitution instead.

Also prefer use the default-sized `SmallVector` as by the LLVM programmer's manual: https://llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h.



>From 2b2d6d5f2aaa90ce8da39bbcb0725612552ff7ba Mon Sep 17 00:00:00 2001
From: Michael Kruse <llvm-project at meinersbur.de>
Date: Wed, 30 Sep 2026 11:56:43 +0200
Subject: [PATCH 1/2] remove TODO

---
 polly/test/lit.site.cfg.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/polly/test/lit.site.cfg.in b/polly/test/lit.site.cfg.in
index c6163fb806306..d808c5ff04475 100644
--- a/polly/test/lit.site.cfg.in
+++ b/polly/test/lit.site.cfg.in
@@ -27,8 +27,6 @@ for arch in config.targets_to_build.split():
 # directories.
 config.excludes = ['Inputs']
 
-# TODO: Let tests spell out -load-pass-plugin and these options, and remove
-# %loadNPMPolly.
 commonOpts = ''.join(' -plugin-arg=Polly,' + opt for opt in [
     '-polly-process-unprofitable',
     '-polly-remarks-minimal',

>From 94c1d5d84ee65c2d0c83aae3acf861004077fbaf Mon Sep 17 00:00:00 2001
From: Michael Kruse <llvm-project at meinersbur.de>
Date: Wed, 30 Sep 2026 11:59:56 +0200
Subject: [PATCH 2/2] Follow LLVM's programmer's manual

---
 polly/lib/Support/RegisterPasses.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/polly/lib/Support/RegisterPasses.cpp b/polly/lib/Support/RegisterPasses.cpp
index e7ca2c4672479..bd3264fb2e4b5 100644
--- a/polly/lib/Support/RegisterPasses.cpp
+++ b/polly/lib/Support/RegisterPasses.cpp
@@ -692,7 +692,7 @@ void registerPollyPasses(PassBuilder &PB) {
 } // namespace polly
 
 static Error parseArguments(ArrayRef<const char *> Args) {
-  SmallVector<const char *, 0> Argv = {"Polly"};
+  SmallVector<const char *> Argv = {"Polly"};
   append_range(Argv, Args);
   std::string Msg;
   raw_string_ostream OS(Msg);