[llvm] [mlir] [Support] Extract SourceMgrDiagnosticVerifier from MLIR's verifier handler. NFC (PR #227565)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 29 22:55:16 PDT 2026
github-actions[bot] wrote:
<!--LLVM IDS CHECK COMMENT-->
:warning: LLVM ABI annotation checker, ids-check found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
Build idt from compnerd/ids, then for each changed header:
idt -p build/ --main-file <matching-source.cpp> \
--apply-fixits --inplace <header>
``````````
</details>
<details>
<summary>
View the diff from ids-check here.
</summary>
``````````diff
diff --git a/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h b/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
index cbb4643eb..d567aa9c8 100644
--- a/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
+++ b/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
@@ -41,16 +41,16 @@ public:
}
/// Returns true if this diagnostic matches the given message.
- bool match(StringRef str) const;
+ LLVM_ABI bool match(StringRef str) const;
/// Computes the regex matcher for a '-re' diagnostic's substring.
/// Returns false and prints a message through \p mgr on error.
- bool computeRegex(raw_ostream &os, SourceMgr &mgr);
+ LLVM_ABI bool computeRegex(raw_ostream &os, SourceMgr &mgr);
/// Prints \p msg at this diagnostic's location and returns false, for
/// use as `return emitError(...);` in functions that report failure via
/// a bool return.
- bool emitError(raw_ostream &os, SourceMgr &mgr, const Twine &msg) const;
+ LLVM_ABI bool emitError(raw_ostream &os, SourceMgr &mgr, const Twine &msg) const;
/// The severity of the diagnostic expected.
SourceMgr::DiagKind kind;
``````````
</details>
https://github.com/llvm/llvm-project/pull/227565
More information about the llvm-commits
mailing list